tcpdump mailing list archives
Re: [RFC PATCH 0/2]: hw timestamp support
From: "Mcmillan, Scott A" <scott.a.mcmillan () intel com>
Date: Mon, 23 Aug 2010 12:17:58 -0700
Guy, Thank you for significantly improving and merging this capability into the official repository. I fully agree with your changes. I was thinking that way myself, but was hesitant to propose changes of that degree as my first contribution. As I was testing your changes, I noticed some very minor build issues, resolved by this small patch: --- a/pcap-linux.c 2010-08-22 19:09:50.000000000 -0500 +++ b/pcap-linux.c 2010-08-23 13:50:08.000000000 -0500 @@ -435,7 +435,7 @@ } handle->tstamp_type_list[0] = PCAP_TSTAMP_HOST; handle->tstamp_type_list[1] = PCAP_TSTAMP_ADAPTER; - handle->tstamp_type_list[2] = PCAP_TSTAMP_ADAPTER_UNSYNC; + handle->tstamp_type_list[2] = PCAP_TSTAMP_ADAPTER_UNSYNCED; #endif return handle; @@ -3234,7 +3234,7 @@ * time stamps. We'll just fall back * on the standard host time stamps. */ - *status = PCAP_WARNING_TSTAMP_TYPE_NOTSUP: + *status = PCAP_WARNING_TSTAMP_TYPE_NOTSUP; break; default: There are also some cases of UNSYNC, rather than UNSYNCED, in the documentation: --- a/pcap/pcap.h 2010-08-22 19:09:50.000000000 -0500 +++ b/pcap/pcap.h 2010-08-23 14:06:21.000000000 -0500 @@ -310,7 +310,7 @@ * PCAP_TSTAMP_ADAPTER is a high-precision time stamp supplied by the * capture device; it's synchronized with the system clock. * - * PCAP_TSTAMP_ADAPTER_UNSYNC is a high-precision time stamp supplied by + * PCAP_TSTAMP_ADAPTER_UNSYNCED is a high-precision time stamp supplied by * the capture device; it's not synchronized with the system clock. * * Note that time stamps synchronized with the system clock can go --- a/pcap-tstamp.manmisc.in 2010-08-22 19:09:50.000000000 -0500 +++ b/pcap-tstamp.manmisc.in 2010-08-23 14:06:37.000000000 -0500 @@ -116,7 +116,7 @@ done. This is a high-precision time stamp, synchronized with the host operating system's clock. .TP 5 -.BR PCAP_TSTAMP_ADAPTER_UNSYNC +.BR PCAP_TSTAMP_ADAPTER_UNSYNCED Time stamp provided by the network adapter on which the capture is being done. This is a high-precision time stamp; it is not synchronized with the host operating system's clock. Thanks, Scott - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Re: [RFC PATCH 0/2]: hw timestamp support Guy Harris (Aug 22)
- Re: [RFC PATCH 0/2]: hw timestamp support Mcmillan, Scott A (Aug 23)
- Re: [RFC PATCH 0/2]: hw timestamp support Guy Harris (Aug 23)
- Re: [RFC PATCH 0/2]: hw timestamp support Mcmillan, Scott A (Aug 23)