tcpdump mailing list archives
Re: [net-2.6 PATCH] af_packet: move strict addr_len check right
From: David Miller <davem () davemloft net>
Date: Wed, 03 Mar 2010 01:06:41 -0800 (PST)
From: Jiri Pirko <jpirko () redhat com> Date: Wed, 3 Mar 2010 07:40:01 +0100
Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed the length check in packet_mc_add to be more strict. The problem is that userspace is not filling this field (and it stays zeroed) in case of setting PACKET_MR_PROMISC or PACKET_MR_ALLMULTI. So move the strict check to the point in path where the addr_len must be set correctly. Signed-off-by: Jiri Pirko <jpirko () redhat com>
Applied. - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Current wireless-testing breaks libpcap: mr_alen should be set Pavel Roskin (Mar 02)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set John W. Linville (Mar 02)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Jiri Pirko (Mar 02)
- [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Eric Dumazet (Mar 02)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right Jiri Pirko (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: [net-2.6 PATCH] af_packet: move strict addr_len check right David Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller (Mar 03)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 03)
- Re: Current wireless-testing breaks libpcap: mr_alen should be set Guy Harris (Mar 06)
- Re: Current wireless-testing breaks libpcap: Jiri Pirko (Mar 08)