Re: [PATCH] SocketCAN support for libpcap - draft

[Guy Harris <guy () alum mit edu>]

On Dec 8, 2009, at 3:03 PM, Felix Obenhuber wrote:

> During capture from a can interface the relevant fields (here struct
> can_frame.can_id ) have to be passed to callback() in network byte
> order. This means to swap on le platforms - for short htonl.
>
> cf = (struct can_frame*)&handle->buffer[8];
> cf->can_id = htonl( cf->can_id );

OK, that sounds good.

I've checked in the latest version of your patch, with can_id being converted to network byte order.

However, the configure script checks for a <linux/can/version.h> header file - but I don't see any such header file in 
the 2.6.29 kernel, although I see the other header files, and the code doesn't seem to include <linux/can/version.h>.  
Should it be checking for a different header file, such as <linux/can.h>?
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.