Re: Printing of TCP flags seems incorrect

[Guy Harris <guy () alum mit edu>]

grarpamp wrote:
> Hi. Patch inline. I conformed the naming to the RFC's

I assume by "naming" you are referring not only to the bits used to 
print the flags in tcpdump but also the flag values used in libpcap for 
filters.

Perhaps a name using the "psh" abbreviation used by RFC 793 for the 
"push" flag, namely "tcp-psh", should be *one of* the names allowed for 
that flag, but the name for that flag supported by libpcap going back at 
least as far as libpcap 0.7 and documented in the tcpdump man page going 
back at least as far as tcpdump 3.7, namely "tcp-push", should also be 
allowed, because people might already have filters using "tcp-push".

> FYI, tcpreplay has problems installing its man page because the
> directory for it is not created by the makefile.

FYI, tcpreplay is not distributed or maintained by tcpdump.org, so 
there's nothing tcpdump.org should do about that.  The libpcap makefile 
creates the $(DESTDIR)$(mandir)/man3 directory - and the 
$(DESTDIR)$(mandir)/man4 directory, in the top-of-tree CVS version of 
libpcap - so it creates all the directories in which it installs its man 
page in current releases and its man pages in the top-of-tree CVS 
version, and the tcpdump makefile creates the $(DESTDIR)$(mandir)/man1 
directory, so it creates all the directories in which it installs its 
man page.  If tcpreplay's Makefile doesn't create target directories for 
*its* man pages before trying to install them, that's a tcpreplay bug, 
and is probably best reported at

        http://tcpreplay.synfin.net/trac/newticket
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.