tcpdump mailing list archives

[PATCH]: pcap-linux: fix invalid rcvbuf size


From: Patrick McHardy <kaber () trash net>
Date: Fri, 18 Jul 2008 19:53:46 +0200

Please keep me CCed since I'm not subscribed to the list.

commit 6f5556e515578c3e034b176562633987e85782e5
Author: Patrick McHardy <kaber () trash net>
Date:   Fri Jul 18 19:22:52 2008 +0200

    pcap-linux: fix invalid rcvbuf size
    
    Libpcap issues a SO_RCVBUF when the buffer size if unspecified (zero).
    The intention appears to be to set it when its *not* zero.

diff --git a/pcap-linux.c b/pcap-linux.c
index d9f9f10..d4c06cb 100644
--- a/pcap-linux.c
+++ b/pcap-linux.c
@@ -557,7 +557,7 @@ pcap_activate_linux(pcap_t *handle)
                goto fail;
        }
 
-       if (handle->opt.buffer_size == 0) {
+       if (handle->opt.buffer_size != 0) {
                /*
                 * Set the socket buffer size to the specified value.
                 */
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.

Current thread: