tcpdump mailing list archives

Re: Libpcap reentrancy and PF_RING patch


From: Guy Harris <guy () alum mit edu>
Date: Sun, 06 Jan 2008 12:54:16 -0800

Luca Deri wrote:

your comments are very valuable: thanks. I have enclosed a new patch that should address all of them.

It's still not a context or unified diff, and I've subsequently made some changes to pcap-linux.c to move the SITA support code into pcap-sita.c, so the patch didn't apply correctly.

Also:

Would it work better if, for PF_RING sockets, there were a separate pcap_read_pf_ring, and handle->read_op were set to pcap_read_pf_ring if a PF_RING socket were being used? That'd avoid some per-packet checks in the read_op routine, and might involve fewer #ifdefs as well.
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: