Re: print-tcp.c: remove commas from output, to be consistent

[Hannes Gredler <hannes () juniper net>]

well the correct thing would then be:

1. embrace .SFP into Flags [.SPF],
2. add commas to sep. the rest of the field

/hannes

On Wed, Jan 17, 2007 at 07:25:07PM -0800, Kevin Steves wrote:
| On Wed, Jan 17, 2007 at 11:42:48PM +0100, Hannes Gredler wrote:
| : can you re-explain your concern ?
| : we use the comma here as a means of seperating
| : fields suitable to human-processors.
| 
| 3 main issues:
| 
| 0) not consistent with rest of tcp output (no commas used)
| 1) distracts from output (e.g., see below ".,")
| 2) output different when vflag and not vflag (e.g., "F," vs. "F")
| 
| ".,":
| 
| 19:13:32.259206 IP (tos 0x60, ttl 45, id 11824, offset 0, flags [DF], proto TCP (6), length 52) 66.94.231.252.80 > 
10.66.203.28.20506: ., cksum 0x8667 (correct), ack 859 win 32832 <nop,nop,timestamp 1259586560 3297975894>
| 
| with vflag:
| 
| 19:13:32.120362 IP (tos 0x0, ttl 64, id 3028, offset 0, flags [DF], proto TCP (6), length 52) 10.66.203.28.20506 > 
66.94.231.252.80: F, cksum 0xc6b8 (correct), 858:858(0) ack 555 win 16384 <nop,nop,timestamp 3297975894 1259586543>
| 
| no vflag:
| 
| 19:13:32.120362 IP 10.66.203.28.20506 > 66.94.231.252.80: F 858:858(0) ack 555 win 16384 <nop,nop,timestamp 
3297975894 1259586543>
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.