tcpdump mailing list archives

Re: print-ip.c: why print ttl with %3u ?


From: Hannes Gredler <hannes () juniper net>
Date: Wed, 17 Jan 2007 18:55:09 +0100

ahh now i get you ... the ttl %3u change was introduced _before_
we decided to print the ID-field ... and this made multiline
outputs more readable ...

checked in your fix into head.

On Wed, Jan 17, 2007 at 09:32:47AM -0800, Kevin Steves wrote:
| not sure what you mean here.
| 
| how would it apply to the following?
| 
| 09:31:09.559173 IP (tos 0x10, ttl  64, id 49030, offset 0, flags [none], proto UDP (17), length 76) 
10.66.203.33.22235 > 209.44.12.114.123: [udp sum ok] NTPv4, length 48
| 
| On Wed, Jan 17, 2007 at 03:04:43PM +0100, Hannes Gredler wrote:
| : but it removes all trailing columns (ip addresses) and makes things more unreadable ...
| : 
| : On Sun, Jan 14, 2007 at 02:20:41PM -0800, Kevin Steves wrote:
| : | this seems nicer without extra spaces.
| : | 
| : | Index: print-ip.c
| : | ===================================================================
| : | RCS file: /tcpdump/master/tcpdump/print-ip.c,v
| : | retrieving revision 1.155
| : | diff -u -r1.155 print-ip.c
| : | --- print-ip.c    19 Feb 2006 05:00:19 -0000      1.155
| : | +++ print-ip.c    14 Jan 2007 22:17:53 -0000
| : | @@ -633,7 +633,7 @@
| : |              }
| : |  
| : |              if (ipds->ip->ip_ttl >= 1)
| : | -                (void)printf(", ttl %3u", ipds->ip->ip_ttl);    
| : | +                (void)printf(", ttl %u", ipds->ip->ip_ttl);
| : |  
| : |       /*
| : |        * for the firewall guys, print id, offset.
| : | -
| : | This is the tcpdump-workers list.
| : | Visit https://cod.sandelman.ca/ to unsubscribe.
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: