tcpdump mailing list archives

Re: print-ip.c: no colons here to be consistent


From: Hannes Gredler <hannes () juniper net>
Date: Wed, 17 Jan 2007 15:09:58 +0100

checked into head and 3.9 branch. - /hannes

Kevin Steves wrote:
the other fields don't print 'field: value' so don't here either.

Index: print-ip.c
===================================================================
RCS file: /tcpdump/master/tcpdump/print-ip.c,v
retrieving revision 1.155
diff -u -r1.155 print-ip.c
--- print-ip.c        19 Feb 2006 05:00:19 -0000      1.155
+++ print-ip.c        15 Jan 2007 21:03:37 -0000
@@ -641,14 +641,14 @@
           * For unfragmented datagrams, note the don't fragment flag.
           */
 
-         (void)printf(", id %u, offset %u, flags [%s], proto: %s (%u)",
+         (void)printf(", id %u, offset %u, flags [%s], proto %s (%u)",
                          EXTRACT_16BITS(&ipds->ip->ip_id),
                          (ipds->off & 0x1fff) * 8,
-                         bittok2str(ip_frag_values, "none", ipds->off&0xe000 ),
+                         bittok2str(ip_frag_values, "none", ipds->off&0xe000),
                          tok2str(ipproto_values,"unknown",ipds->ip->ip_p),
                          ipds->ip->ip_p);
 
-            (void)printf(", length: %u", EXTRACT_16BITS(&ipds->ip->ip_len));
+            (void)printf(", length %u", EXTRACT_16BITS(&ipds->ip->ip_len));
 
             if ((hlen - sizeof(struct ip)) > 0) {
                 printf(", options (");
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: