Re: [PATCH]: [DCCP]: support for variable-length checksums

["Ian McDonald" <ian.mcdonald () jandi co nz>]

On 10/31/06, Gerrit Renker <gerrit () erg abdn ac uk> wrote:
> This introduces support for variable-length checksum in
> DCCP, as it is specified in section 9 of RFC 4340.
>
> Previously tcpdump was only able to validate full-coverage
> checksums, this patch verifies checksums in accordance with
> the CsCov header field (sec. 5.3).
>
> The patch has been tested and verified on DCCPv4 and DCCPv6
> connections, checksums were manually validated, and traces
> can be supplied.
>
>
>
> In addition, the patch also
>         * removes reduplicated code in dccp6_cksum (which
>           just repeated the code of in_cksum)
>         * fixes a bug in dccp.h -- the fields of CCVAL and
>           CSCOV were swapped (cf. section 5.1 of RFC 4340)
>         * fixes a typo in the display of incorrect checksums
>           (these were printed as `cksum xDEAD (incorrect (->  xBEEF)',
>            it now will print  `cksum xDEAD (incorrect -> xBEEF)'
>
> I would like to see this merged as a Linux kernel patch already
> exists for DCCP partial checksum coverage support.
I would agree with this going ahead and in particular I remember the
CCVAL bug and then forgetting to fix it...

--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.