tcpdump mailing list archives

Creeping GCC'sims in tcpdump


From: Brian Ginsbach <ginsbach () cray com>
Date: Mon, 12 Apr 2004 09:48:52 -0500

The following in netdissect.h seems like a bad thing to do.
 
#define ND_PRINT(fmt, args...) (*ndo->ndo_printf)(ndo, fmt, ##args)
 
Not all compilers/preprocessors support variable argument macros
like GCC.  Compiling tcpdump shouldn't require GCC or a C99 compiler.
This macro is only used once in print-eap.c.  Its use should
be nipped in the bud.

(After an earlier private exchange with Guy about this issue, he
felt it was more general and should be brought up on tcpdump-workers.)

-- 
Brian Ginsbach                          Cray Inc.
-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.


Current thread: