tcpdump mailing list archives

Re: What happened to alarm()?


From: Guy Harris <guy () alum mit edu>
Date: Sat, 29 Nov 2003 17:15:34 -0800

On Sun, Nov 30, 2003 at 01:43:32AM +0100, Gisle Vanem wrote:
"Guy Harris" <guy () alum mit edu> said:

"pcap_break_loop()" shouldn't make things worse; I'll look at that.

There's an error in pcap_read_win32() where 'p->break_loop' is
tested only if PacketReceivePacket() received something.
I.e. can't break out of tcpdump on a quiet LAN. Simple fix:

--- pcap-win32.c.orig     Fri Nov 21 01:10:00 2003
+++ pcap-win32.c        Thu Nov 20 03:02:40 2003
@@ -146,7 +119,7 @@
         */
 #define bhp ((struct bpf_hdr *)bp)
        ep = bp + cc;
-       while (1) {
+       while (bp < ep) {

Is that a reverse patch?

I.e., is "pcap-win32.c.orig" the fixed version, with the fix replacing

        while (bp < ep) {

with

        while (1) {

The current CVS version has

        while (bp < ep) {
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe


Current thread: