Re: print-esp.c patch

[Guy Harris <gharris () sonic net>]

On Sat, Mar 01, 2003 at 03:29:34PM +0100, Gisle Vanem wrote:
> I finally finished the print-esp.c patch so it works with all (?) OpenSSL
> versions. Missing strsep (for MingW32/Watcom etc) is added in 
> missing/strsep.c (borrowed from djgpp).

Is it GPLed?  The comment just speaks of a "COPYING.DJ" file.

I'll use the BSD "strsep.c" instead, just to be sure there isn't a
license clash.

> Some patches to tcpdump-stdinc.h needed:
>   * A header guard.
>   * toascii() macro missing in Watcom.
>   * Defines for fopen() read/write mode

Is the "t" necessary for text on any DOS/Windows platforms?  Or is it
always the case that "r" and "w" give you text mode?

>     (what mode does MacOS use for opening text/binary files?)

I don't know what MacOS prior to MacOS X uses.  Has anybody ported
tcpdump to pre-X MacOS?

MacOS X, in the environment in which tcpdump is built, uses "r" and "w"
for opening text files, and "r" and "w" for opening binary files, which
should not come as a surprise. :-)

> print-esp.c:
>   * addrinfo.h needed for inet_pton()
>   * I have no idea how to add HAVE_STRSEP to the configure process.

If by "the configure process" you mean the process performed by the
configure script, that's done with AC_REPLACE_FUNCS; I've added it to
the list of string functions in the AC_REPLACE_FUNCS in configure.in.

I've checked your changes in, along with an update to FILES to include
missing/strsep.c.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe