Re: Problems with removing alignment stuff in IP dissector

[Jun-ichiro itojun Hagino <itojun () iijlab net>]

> So should we undo that change, or should we go through and, at minimum,
> convert all 4-byte accesses to use EXTRACT_32BITS()?  (Presumably
> little-endian fetches are already using EXTRACT_LE_32BITS().)
> If so, I'd say we should convert 2-byte accesses to use
> EXTRACT_16BITS(), just to be sure.

        we can't undo the change, the code in print-{ip,ip6,arp}.c had severe
        memory leaks.  i guess we should start converting accesses to
        EXTRACT_foo.

itojun
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe