Re: Missing pcap_dump_flush

[Guy Harris <gharris () sonic net>]

On Sun, Dec 22, 2002 at 05:03:20PM +0100, Gisle Vanem wrote:
> WinPcap 3.0 alpha 4 doesn't have 'pcap_dump_flush()' so the following patch is
> needed in tcpdump.c:

Unfortunately, that patch will be *un*wanted when the next version of
WinPcap comes out - and I presume the final version of WinPcap will be
based on libpcap 0.8 as released (which will include
"pcap_dump_flush()") and the final version of WinDump will be based on
tcpdump 3.8 as released (which means it *should* use
"pcap_dump_flush()").

The right fix is to

        1) arrange that the current CVS versions of GNUmakefile and
           WinDump.dsp define HAVE_PCAP_DUMP_FLUSH, so that it builds
           correctly with the current CVS version of WinPcap;

        2) use the WIN32 #define only to determine whether "-B" is
           supported or not, not whether "-D" or "-U" are supported;

        3) have people building the current CVS version of
           tcpdump/WinDump with older versions of WinPcap tweak
           GNUmakefile or WinDump.dsp not to define
           HAVE_PCAP_FINDALLDEVS if their WinPcap doesn't have it and
           not to define HAVE_PCAP_DUMP_FLUSH if their WinPcap doesn't
           have it.

I will do 1) and 2), as well as checking in your change to check the
appropriate #define when checking whether "pcap_dump_flush()" exists.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe