Re: [PATCH][RESEND]: Use uint8_t for protocol in some Stream5functions

[<Joshua.Kinard () us-cert gov>]

Hi snort-devel,

Resending.  I forgot to change the argument list in two functions in
typedef StreamApi.h in src/preprocessors/stream_api.h.

--J

> I noticed that for several function calls in the Stream5 code, a
signed char
> was being used for the protocol.  Right now, supported Snort
protocols, ICMP,
> TCP, and UDP, are all under 128 (1, 6, and 17).  For for protocols
> 128, this
> would roll over into a negative number, making a conditional on the
IPPROTO_*
> macro useless because those macros are only returning a positive
number
> between 1 and 255.
>
> Per include/linux/in.h (as of 3.0), this would affect IPPROTO_SCTP and
> IPPROTO_UDPLITE.
>
> Patch is attached.  There might be more cases in the code, but I only
did a
> quick grep for "char proto" and fixed the obvious cases.  Other
'protocol'
> variables are already uint8_t.

Attachment: snort-291-protocol-should-be-unsigned.patch
Description: snort-291-protocol-should-be-unsigned.patch

------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the 
BlackBerry® mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry® DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1

_______________________________________________
Snort-devel mailing list
Snort-devel () lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/snort-devel

Please visit http://blog.snort.org for the latest news about Snort!