oss-sec mailing list archives

Re: Geany IDE not escaping filenames during compilation / build - a security issue or not?


From: Andreas Ericsson <ae () op5 se>
Date: Thu, 13 Dec 2012 14:31:26 +0100

On 12/13/2012 07:50 AM, Matthew Brush wrote:
On 12-12-12 09:54 PM, Eitan Adler wrote:
On 12 December 2012 11:51, Jan Lieskovsky <jlieskov () redhat com>
wrote:
The questions: 1) should Geany escape the filenames?,

Up to the maintainers.

2) is this a security issue or not?

Unlikely.  Is there a way a malicious document could cause code 
execution without user action?


If I understand correctly, if someone messed with the user's
configuration directory where the "geany.conf" file is stored, and
they modified the "recent files" stored in there that Geany opens
automatically on next startup, then assuming that it doesn't choke on
the weird filename and that the user didn't notice the weird filename
in several places in the GUI, they could technically blindly activate
a build command, causing the malicious filename/command to run.


If someone has access to modify a users home directory, it's safe to
assume that they can execute commands as that user. It's like saying
"if someone gains root access to your system, they can replace your
binaries with trojan kits that open them up to remote root access".
It's not really a security issue if you can gain access you already
have.

-- 
Andreas Ericsson                   andreas.ericsson () op5 se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.


Current thread: