Re: CVE Request: powerdns does not clear supplementary groups

[Solar Designer <solar () openwall com>]

On Thu, May 24, 2012 at 06:15:53PM -0400, Steve Grubb wrote:
> Here is a real life case:
>
> + if ( initgroups(pw->pw_name, NULL) != 0 || setgid(pw->pw_gid) != 0 ||
> +                                setuid(pw->pw_uid) != 0 ) 
>
> This is not upstream. This is a patch to drop capabilities by changing uid/gid. 
> The person writing the patch intended to do the right thing - but failed. See 
> the bug? This is in a network facing daemon that parses untrusted network 
> packets.

Wow.  The NULL results in group 0 being added to the supplementary
groups list (so it survives the setgid(), at least on my quick test).

How did you spot this?  Compiler warning?

"passing arg 2 of `initgroups' makes integer from pointer without a cast"

Alexander