oss-sec mailing list archives
Re: CVE Request (gpicview)
From: Nico Golde <oss-security+ml () ngolde de>
Date: Thu, 4 Sep 2008 17:17:57 +0200
Hi, * Robert Buchholz <rbu () gentoo org> [2008-09-03 11:22]:
On Sunday 31 August 2008, Nico Golde wrote:Same piece of code main-win.c doesn't look too trustworthy to me either: 690 int error = jpegtran (filename, "/tmp/rot.jpg" , code); 691 if(error) 692 return error; 693 694 //now copy /tmp/rot.jpg back to the original file 695 char command[strlen(filename)+50]; //this should not generate buffer owerflow 696 // MS: didn't know, how to make it better, maybe an own copy routine 697 sprintf(command,"cp /tmp/rot.jpg \"%s\"",filename); 698 system(command); Anyone played with crafted file names?Good catch! You need to append '.jpg' at the end of the crafed filename so the rotation via jpegtran is invoked, but besides that it works ok:
[...] Can we get a second CVE id for this then please? Kind regards Nico -- Nico Golde - http://www.ngolde.de - nion () jabber ccc de - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted.
Attachment:
_bin
Description:
Current thread:
- CVE Request (gpicview) Jan Lieskovsky (Aug 25)
- Re: CVE Request (gpicview) Steven M. Christey (Aug 26)
- Re: CVE Request (gpicview) Jan Lieskovsky (Aug 26)
- Re: CVE Request (gpicview) Robert Buchholz (Sep 13)
- Re: CVE Request (gpicview) Nico Golde (Aug 30)
- Re: CVE Request (gpicview) Jan Lieskovsky (Aug 31)
- Re: CVE Request (gpicview) Nico Golde (Sep 04)
- Re: CVE Request (gpicview) Robert Buchholz (Sep 02)
- Re: CVE Request (gpicview) Nico Golde (Sep 04)
- Re: CVE Request (gpicview) Steven M. Christey (Sep 04)
- Re: CVE Request (gpicview) Jan Lieskovsky (Aug 31)
- Re: CVE Request (gpicview) Steven M. Christey (Aug 26)