Nmap Development mailing list archives

GitHub PR#1418 Review


From: Karuna Grewal <karunagrewal98 () gmail com>
Date: Wed, 19 Dec 2018 23:37:21 +0530

Hi everyone!
I've created a pull request (https://github.com/nmap/nmap/pull/1418)
which addresses a FIXME issue in one of the ncat files.

As a means to optimize the loop which intends to iterate over the read
file descriptors, I've changed the original traversal from 0 to
max_fd. Now, it checks only those specific file descriptors which are
inserted into the appropriate file descriptor list which makes it
efficient.

Waiting for reviews. Please let me know if any changes need to be made.
Thank you in advance!
Karuna Grewal
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/


Current thread: