Re: NSE: add script for discovering OSPF neighbors

[Emiliano Ticci <emiticci () gmail com>]

Daniel,

Just to be 100% sure you won't release a new version with a buggy library,
I might point out this PR:

https://github.com/nmap/nmap/pull/761

Thanks again,
Emiliano

On Mon, Mar 13, 2017 at 10:05 PM, Emiliano Ticci <emiticci () gmail com> wrote:

> Thanks Dan,
>
> I've just updated the pull request. Regarding bin/bit, I think I've found
> a way to go, but as per your suggestion I'll wait for the merge before
> making that change.
>
> Thanks again,
> E.
>
> On Mon, Mar 13, 2017 at 7:07 PM, Daniel Miller <bonsaiviking () gmail com>
> wrote:
>
> > Emiliano,
> >
> > Thanks for this! I've left a comment on Github regarding how the script
> > should function if OpenSSL is not present, and then we'll be ready to
> > accept this. Regarding converting from bin/bit, I suggest we wait until the
> > script and the original ospf.lua changes to be merged. That way the diff is
> > smaller and we can see what changed.
> >
> > Dan
> >
> > On Sat, Mar 11, 2017 at 6:35 AM, Emiliano Ticci <emiticci () gmail com>
> > wrote:
> >
> > > Hi!!
> > >
> > > I'd like to contribute to the project by sharing a script for
> > > discovering OSPF neighbors.
> > >
> > > To make the script work, I've made several additions to the ospf
> > > library, and also a small addition to ipOps. I've also considered to
> > > partially rewrite the ospf library using Lua native functions instead
> > > bin/bit, but I stopped because (maybe due to my poor Lua skills) I didn't
> > > found a convenient way to handle hex strings.
> > >
> > > All is included into pull request 743
> > > <https://github.com/nmap/nmap/pull/743> on github, comments are welcome!
> > >
> > > Thanks,
> > > E.
> > >
> > > _______________________________________________
> > > Sent through the dev mailing list
> > > https://nmap.org/mailman/listinfo/dev
> > > Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/