Re: Completed Lua 5.3 upgrade!

[Daniel Miller <bonsaiviking () gmail com>]

Patrick,

I found another anomaly, but I'm not sure the best way to fix it. It seems
that the previous bin.unpack() treated index 0 as equivalent to 1, meaning
the beginning of the string. The new one instead returns 1 for the next
index and nil for any unpacked values. So far, I've only identified
ssl-date.nse and tls-nextprotoneg.nse as being affected, since they pass 0
to tls.record_read, which gets used directly in a call to bin.unpack. I'm
fixing those in the current trunk, but there may be other odd places this
crops up as an off-by-one bug.

Dan

On Fri, Jun 17, 2016 at 7:43 PM, Patrick Donnelly <batrick () batbytes com>
wrote:

> On Wed, Jun 8, 2016 at 9:31 PM, Patrick Donnelly <batrick () batbytes com>
> wrote:
> > Without further ado, here's the branch:
> >
> > https://github.com/batrick/nmap/tree/nse-lua53
>
> If there are no questions/comments/complaints/objections, I'd like to
> merge the branch sometime around next Friday. All feedback is still
> welcome!
>
> --
> Patrick Donnelly
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/