Re: Wrong bounds in vectorize_hlim

[Daniel Miller <bonsaiviking () gmail com>]

We discussed in a separate meeting not trying to coerce this value into a
power of 2, but simply using the guessed initial hlim directly as a
feature. I have not yet done a cross-validation with that change, but I
expect it will not have a big impact, and will eliminate or reduce
arbitrary limits like the 5-hop buffer for asymmetric routes (er_lim).

Dan

On Wed, Jun 10, 2015 at 10:11 PM, David Fifield <david () bamsoftware com>
wrote:

> vectorize_hlim (both the C++ and Python versions) have lines like this:
>
>         if (32 - er_lim <= hlim && hlim <= 32 + 5)
>
> It looks like it should rather be
>
>         if (32 - er_lim <= hlim && hlim <= 32 + er_lim)
>
> i.e., hlim lies within the interval 32±er_lim.
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/