Re: Use of ISO646 feature

[Daniel Miller <bonsaiviking () gmail com>]

Gisle,

On Sun, Apr 5, 2015 at 7:43 AM, Gisle Vanem <gvanem () yahoo no> wrote:

> While compiling Nnap (latest SVN-repo version) using MSVC v18, I see
> this:
>
> cl -nologo .. -c TargetGroup.cc
> TargetGroup.cc(641) : error C2146: syntax error : missing ')' before
> identifier 'or'
> TargetGroup.cc(641) : error C2065: 'or' : undeclared identifier
>
> (gcc includes iso646.h/ciso646 internally). So can you please add
> a '#include <ciso646>' somewhere? Or just drop those IMHO silly ISO/C++
> features.
>
> The history of TargetGroup.cc:
>   https://github.com/nmap/nmap/commits/master/TargetGroup.cc
>
> don't indicate when this was added. Is the version at Github unrelated
> to the real thing at svn.nmap.org/nmap?
I'm sorry, I introduced this on 11 March in r34089. I did not intend to use
such an odd feature, and I'm surprised it compiled at all. My mind must not
have been working in C mode. Do you know of a good way to check for
non-standard features like this that I could add to my commit hooks?


> And BTW, there are issues with the lastest OpenSSL;
> cl ... -c nse_openssl.cc
>   nse_openssl.cc(100) : error C3861: 'BN_CTX_init': identifier not found
>
> The Heartbleed bug last year have created panic among the OpenSSL
> developers. So they've hidden this function and the layout of 'BN_CTX'
> i.e. 'struct bignum_ctx'.


Thanks for the heads-up! I'll look into this and hopefully have a fix soon.

Dan

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/