Re: [Bulk] Re: [Patch] 'static inline' and MSVC

[Henri Doreau <henri.doreau () gmail com>]

2014-02-12 11:40 GMT+01:00 Gisle Vanem <gvanem () yahoo no>:
> "Henri Doreau" <henri.doreau () gmail com> wrote:
>
> > > MSVC v16 has no 'inline' in C, but '__inline'. Not sure if a more
> > > recent MSVC has a native 'inline'. Looking at how libpcap does this, I
> > > don't
> > > think so.  A patch that works for me:
>
> ...
>
>
> > My bad, I wasn't expecting this to break anything. How does MSVC deal
> > w/ the inline functions that are defined in nsock_internal.h[1] for
> > instance? We don't compile nsock as C++, do we?
>
>
> No we don't (and we probably can't?). For nsock/src, I just do 'CFLAGS +=
> -Dinline=__inline'. A hack, but it works.
>
> OTOH, the .c-files under ncat *must* be compiled as C++ (option -TP)
> when using MSVC v16. See my update to Jacek's reply.
>
>
> --gv

Ok, I have committed your patch for nbase as r32750.
Thanks

-- 
Henri
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/