Nmap Development mailing list archives
Re: uint8_t on MingW
From: Jacek Wielemborek <wielemborekj1 () gmail com>
Date: Thu, 15 Aug 2013 00:00:07 +0200
#define HAVE_IPV6 1 #define HAVE_AF_INET6 1 @@ -164,5 +166,7 @@ #define HAVE_OPENSSL 1 /* Apparently __func__ isn't yet supported */ #define __func__ __FUNCTION__ + +#undef interface #endif /* NBASE_WINCONFIG_H */ ----------------- Besides, I've undef'ed 'interface' since it's defined to something else in a MingW/Win32 SDK header. --gv _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Hi, I thought I'd copy a part of my meeting with David to clarify why this patch didn't get merged: 19:17:27 yyzfp$ See, and that's exactly the kind of patch that's not clean enough. 19:17:28 d33tah$ didn't need the #undef interface, but those typedefs just don't work on MinGW 19:17:32 yyzfp$ For exampe, 19:17:45 yyzfp$ is __MINGW32__ really the thing we want to test for here? 19:18:02 yyzfp$ Is there a more appropriate define in stdint.h that we could test for, that's not specific to __MINGW32__? 19:18:21 yyzfp$ I don't know what's up with the interface undef. Gisle, could you clarify the problem? Yours, Jacek Wielemborek _______________________________________________ Sent through the dev mailing list http://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: uint8_t on MingW Jacek Wielemborek (Aug 14)
- Re: uint8_t on MingW Jacek Wielemborek (Aug 14)
- Re: uint8_t on MingW Gisle Vanem (Aug 15)
- Re: uint8_t on MingW Jacek Wielemborek (Aug 15)