Re: [Patch] nsock/tests/tests_main.c

[Gisle Vanem <gvanem () broadpark no>]

"Henri Doreau" <henri.doreau () gmail com> wrote:

> Why do they both initialize winsock with different version numbers?

Probably not important. But if one needs IPv6 functions from Winsock,
I imagined one must use MAKEWORD(2,2). Since addrset.c tests IPv6 (if
available), it seems to need 2.2. I cannot see that nsock/tests need IPv6.
Besides, I cannot confirm 2.2 with IPv6 since I run Win-XP without IPv6
installed.

> Does the simple patch attached sound good to you? I've stripped down
> the ANSI colors part. On trunk I simply print results without anything
> fancy when running on windows. They're not important and I'd like to
> keep it very simple. I'd actually rather use no colors at all than
> have complex platform-specific initialization code just for that.

Okay with me.

> I get double declaration errors which I need to investigate, it's
> probably nothing big. I find it ugly as hell but had no time to clean
> it since I noticed.

Many headers in Nmap are ugly; some are not atomic and step
on each other toes. Like you probably have seen.

--gv
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/