Re: Match ICMP echo reply to request in scan_engine.cc

[Chris Johnson <cjohnson () zenoss com>]

http://git.io/nmap-cjohnson-2.diff (also attached)

David Fifield, thanks for the good feedback.

1. You're correct, ping->seq is always zero (so it's erroneous to check for it).
2. I disagree with the suggestion of storing icmp_ident in probespec_icmpdata. The ident value is (ideally) unique to 
each probe.
3. I've created an icmp_probe_match helper function, as suggested.

 - chris

Attachment: nmap-cjohnson-2.diff
Description:

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/