Nmap Development mailing list archives

Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly

From: Tomas Hozza <thozza () redhat com>
Date: Mon, 11 Feb 2013 04:30:43 -0500 (EST)



----- Original Message -----

On Fri, Feb 08, 2013 at 03:12:45AM -0500, Tomas Hozza wrote:

----- Original Message -----

Looks good, thanks. Can you add a test along the lines of the one
added by Michal Hlavinka for a similar EOF issue?

http://seclists.org/nmap-dev/2012/q4/337
http://seclists.org/nmap-dev/2012/q4/att-337/ncat-shutdown2.patch


Thank you for your reply. I added a new test and also fixed
Michal's test to reflect new behaviour with and without --recv-only option.
Attaching proposed patch for Ncat's testsuite.


Thank you for doing this. It looks like the real purpose of your
earlier patch is not to call shutdown, but just to avoid calling
nsock_loop_quit. shutdown(SHUT_RD) seems to be a no-op; in its place
I added a close(stdout).


You are right. Closing STDOUT makes more sense. Thank you for including the fix.

Regards,

Tomas Hozza

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/

Current thread:

[PATCH] Ncat as a client should quit event loop on EOF only if recvonly Tomas Hozza (Feb 07)
- Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly David Fifield (Feb 07)
  - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly Tomas Hozza (Feb 08)
    - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly David Fifield (Feb 09)
    - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly Tomas Hozza (Feb 11)
  - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly Tomas Hozza (Feb 08)
    - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly David Fifield (Feb 09)
    - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly Tomas Hozza (Feb 18)
    - Re: [PATCH] Ncat as a client should quit event loop on EOF only if recvonly David Fifield (Feb 22)