Re: Some patches

[David Fifield <david () bamsoftware com>]

On Mon, Oct 08, 2012 at 10:56:25AM +0400, arrowdodger wrote:
> > > http://intara.arrowdodger.ru/patch-Makefile-cxxflags-fix
> > >
> > > --- Makefile.in_        2012-10-05 10:17:36.037550752 +0400
> > > +++ Makefile.in 2012-10-05 10:17:08.205548992 +0400
> > > @@ -46,7 +46,7 @@
> > >  # DEFS += -DMTRACE=1
> > >  CXXFLAGS = @CXXFLAGS@ $(DBGFLAGS) $(CCOPT)
> > >  CPPFLAGS = @CPPFLAGS@ $(DEFS)
> > > -export CFLAGS = $(CXXFLAGS)
> > > +export CFLAGS = @CFLAGS@
> > >  # CFLAGS = $(DEFS) $(INCLS)
> > >  STATIC =
> > >  LDFLAGS = @LDFLAGS@ $(DBGFLAGS) $(STATIC)
> >
> > I think it is intentional that CFLAGS is getting a copy of CXXFLAGS, so
> > I didn't commit this.
>
> Well, the flags i use are specific for C++, so clang gives me error:
> error: invalid argument '-std=c++11' not allowed with 'C/ObjC'
> I think it's wrong to mix C and CXX flags, but i'm fine if you leave it as
> it is, since my setup is quite uncommon.

I agree that mixing CFLAGS and CXXFLAGS is slightly bogus. Probably this
should happen at a different step, so that only certain options are
shared and not all of them. But because the effect of setting CFLAGS in
this way isn't known, I want to leave it the way it is until someone
tests to make sure it doesn't break anything. At least, I would like to
see the difference between what ends up in CFLAGS now and what ends up
in CFLAGS if set from @CFLAGS@.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/