Re: ncat - UNIX-domain sockets support

[David Fifield <david () bamsoftware com>]

On Wed, Nov 28, 2012 at 11:04:30AM -0500, Tomas Hozza wrote:
> ----- Original Message -----
> > On Mon, Nov 26, 2012 at 10:44:53AM -0500, Tomas Hozza wrote:
> > > ----- Original Message -----
> > > If the file already exists it is a real problem. The bind() call
> > > will fail
> > > with errno 98 "Address already in use". Therefore when creating
> > > source socket
> > > "file" (when bind() is called) file with the given/generated path
> > > MUST NOT exist.
> >
> > I have made some changes and sommitted your patch. Thank you for
> > spending time on it. My comments are below.
>
> Thank you very much. Unfortunately you removed one extra part of the
> patch that shouldn't be removed by my opinion.
>
> When source socket exist, when Ncat is connecting to a server using
> DATAGRAM UNIX sockets, Ncat should exit. Therefore nsock_connect() should
> return "-1" when bind() returns "-1" in case of UNIX sockets.

My mistake; I have committed a fix.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/