Re: [BUG] nbase.h does not include sys/select.h

[David Fifield <david () bamsoftware com>]

On Sun, Sep 09, 2012 at 08:55:56PM +0200, John Spencer wrote:
> On 09/09/2012 01:06 AM, John Spencer wrote:
>
> > including <sys/select.h> fixes the issue.
>
> here's a patch.

> --- nmap-6.01.org/nbase/nbase.h
> +++ nmap-6.01/nbase/nbase.h
> @@ -126,7 +126,7 @@
>   *
>   * * Various Windows -> UNIX compatability definitions are added (such as defining EMSGSIZE to WSAEMSGSIZE)
>   */
> -
> +#include <sys/select.h>
>  #if HAVE_CONFIG_H
>  #include "nbase_config.h"
>  #else

I think this is taken care of in r29762. <sys/select.h> can't be
included unconditionally because it is not present at least on Windows,
if #ifdef guards elsewhere in the code are to be believed. I added a
configure check for it.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/