Re: [nmap-svn] r29315 - in nmap: nselib scripts

[Patrick Donnelly <batrick () batbytes com>]

On Tue, Jul 24, 2012 at 4:25 PM, Henri Doreau <henri.doreau () gmail com> wrote:
> 2012/7/24  <commit-mailer () insecure org>:
> > Author: patrik
> > Date: Tue Jul 24 03:08:43 2012
> > New Revision: 29315
> >
> > Log:
> > nse_check_globals cleanup
>
> Hello,
>
> I've noticed that many scripts[1], mostly brute ones, use a "Driver"
> variable, whch is not declared as local, and not changed by
> nse_check_globals.
>
> Is this a false negative from nse_check_globals, or is it on purpose
> that these variables are never declared as local? If so, why?

It is not a false negative. Each instantiation of a script (thread)
has its own table of globals. nse_check_globals treats globals that
have been set at the file scrope (e.g. Drivers) to be "declared" and
therefore valid. It wouldn't hurt to change it to local though.

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/