Re: [NSE] New script: http-qnap-nas-info.nse

[Patrik Karlsson <patrik () cqure net>]

On Tue, Jan 31, 2012 at 3:28 PM, Brendan Coles <bcoles () gmail com> wrote:

> Thanks guys. I've attached an update with the suggested changes.
>
>
> On Tue, Jan 31, 2012 at 9:43 AM, David Fifield <david () bamsoftware com>wrote:
>
> > On Sun, Jan 29, 2012 at 05:07:49PM +0100, Patrik Karlsson wrote:
> > > In regards to the property strings, I think we should keep them in the
> > > script for now.
> > > The property table is similar to what I've done in the memcached-info
> > and
> > > membase-http-info and it makes it easy enough to add more entries while
> > > avoiding the additional code handling an external file.
> >
> > I agree with this. The strings are already well factored within the
> > script.
> >
> > David Fifield
> > _______________________________________________
> > Sent through the nmap-dev mailing list
> > http://cgi.insecure.org/mailman/listinfo/nmap-dev
> > Archived at http://seclists.org/nmap-dev/
>
>
>
> --
> Brendan Coles
> http://itsecuritysolutions.org/
Great work! I've committed it as r27984.

Thanks,
//Patrik
-- 
Patrik Karlsson
http://www.cqure.net
http://twitter.com/nevdull77
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/