Nmap Development mailing list archives

Re: Exception fail / crash


From: Henri Doreau <henri.doreau () gmail com>
Date: Mon, 30 Jan 2012 22:55:15 +0100

2012/1/30 Brian Gottreu <gottreu () gmail com>:
I believe the r27949 change only filters out events from ev_inc, and
leaves ev_dec unchanged.  One would need to add a temporary copy of
ev_inc to use for the filtering of ev_dec.

Or if it's rewritten like the attached patch, then there would also be
one fewer XOR performed.  (Though that feels like a silly, prematurely
optimized reason.)

Brian Gottreu

Wow, good catch. Thanks for the report and the patch. I've tested it
and committed it as r27979. I have used your version instead of
re-using the X_EV macro, so that operations are obvious for reader.

Sorry for that trivial error in my code.

Regards.

-- 
Henri
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/


Current thread: