Re: [NSE] Script for HTML generator meta tag

[David Fifield <david () bamsoftware com>]

On Wed, Jan 11, 2012 at 09:01:20AM -0800, David Fifield wrote:
> On Tue, Jan 10, 2012 at 08:34:37PM +0100, Michael Kohl wrote:
> > On Tue, Jan 10, 2012 at 4:33 PM, Daniel Miller <bonsaiviking () gmail com> wrote:
> > > This looks like a great script, and one that I would use frequently.
> >
> > Thanks for the feedback, Daniel!
> >
> > > I could see tightening up the regex in line 40 to use
> > > [^"]* instead of .*, since if you had more than one tag with attributes on
> > > the same line, it would greedily take more than you wanted.
> >
> > Updated the pattern, the version I had was more of quick and dirty way
> > to see if the script works and then I never changed it.
> >
> > > I look forward to seeing this one in the main distribution!
> >
> > Me too, I'll also work on some of Duarte's comments first.
>
> I'm just waiting for a new version of the script that has your planned
> changes and then we'll commit it.

I just committed it. Nice job. Send a patch when you have make any other
changes.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/