Re: [NSE] New script http-put

[Patrik Karlsson <patrik () cqure net>]

Duarte,

Thanks for catching all this!
I agree with all of your suggestions and the categories was a sloppy
cut-paste thing. Sorry for that.
I've committed an updated version as r26917.

Cheers,
Patrik

On Thu, Oct 20, 2011 at 5:34 AM, Duarte Silva
<duarte.silva () serializing me>wrote:

> Hi Patrik,
>
> we all know that coding is always related to personal style, but I think
> the
> use of one liners (specially in code that branches execution flow) makes
> the
> code harder to read and to perceive.
>
> I suggest this to be changed because this is a simple script, a good
> starting
> point for novice contributors, and it would make it easier for them to
> understand.
>
> Another thing, I wanted to suggest is to use the stdnse.format_output
> thingy
> :P
>
> I also have doubts about the categories. I don't think safe is a good
> option
> here. I think uploading a file to a server might be rather intrusive.
>
> Best regards,
> Duarte Silva
>
> On Thursday 20 October 2011 03:34:41 Patrik Karlsson wrote:
> > Hi all,
> >
> > I just committed a new script called http-put which does exactly what the
> > name suggests.
> > It allows you to upload a local file to a remote server supporting the
> HTTP
> > PUT method.
> >
> > Cheers,
> > Patrik
> > _______________________________________________
> > Sent through the nmap-dev mailing list
> > http://cgi.insecure.org/mailman/listinfo/nmap-dev
> > Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/