Nmap Development mailing list archives
Re: [nmap-svn] r25714 - ncat
From: Henri Doreau <henri.doreau () greenbone net>
Date: Wed, 10 Aug 2011 14:02:33 +0200
2011/8/10 <commit-mailer () insecure org>:
Author: david Date: Tue Aug 9 19:19:30 2011 New Revision: 25714 Log: Fix some -Wunused-but-set-variable warnings. Modified: ncat/ncat_listen.c ============================================================================== --- ncat/ncat_listen.c (original) +++ ncat/ncat_listen.c Tue Aug 9 19:19:30 2011 @@ -183,9 +183,6 @@ { int rc, i, fds_ready; fd_set listen_fds; -#ifdef HAVE_OPENSSL - SSL_CTX *ctx; -#endif /* clear out structs */ FD_ZERO(&master_readfds); @@ -208,11 +205,6 @@ Signal(SIGPIPE, SIG_IGN); #endif -#ifdef HAVE_OPENSSL - if (o.ssl) - ctx = setup_ssl_listen(); -#endif - /* We need a list of fds to keep current fdmax. The second parameter is a number added to the supplied connection limit, that will compensate maxfds for the added by default listen and stdin sockets. */
Hello, What was the reason for removing the call to setup_ssl_listen()? This introduced a regression for me. Simply calling setup_ssl_listen() if o.ssl is set, without storing the return value seems to fix it, and won't produce a -Wunused-but-set-variable warning. I don't know the context, so maybe this is inappropriate... Regards. -- Henri Doreau | Greenbone Networks GmbH | http://www.greenbone.net Neuer Graben 17, 49074 Osnabrueck, Germany | AG Osnabrueck, HR B 202460 Executive Directors: Lukas Grunwald, Dr. Jan-Oliver Wagner _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: [nmap-svn] r25714 - ncat Henri Doreau (Aug 10)
- Re: [nmap-svn] r25714 - ncat David Fifield (Aug 10)