Re: Autotools libpcre issue

[Shinnok <admin () shinnok com>]

On 05/24/2011 07:13 PM, David Fifield wrote:
> On Tue, May 24, 2011 at 02:29:32PM +0300, Shinnok wrote:
> > Hi,
> >
> > I have a question regarding the Makefile generated by Autotools in the
> > Nmap distribution:
> >
> > libpcre/pcre.h - is cleared upon make distclean thus leaving the SVN
> > working directory dirty
> >
> > As I see it pcre.h is generated automatically by the pcre toolkit.
> > There is a copy already in the SVN distribution and configure script
> > creates another, thus overwriting the repo one. Upon make distclean,
> > pcre.h is removed since it is supposed to have been generated by the
> > build process. Is pcre.h in the SVN repo for reasons such as a
> > workaround for when that header can not be generated or is it a bug?
>
> Correct, pcre.h is there for Windows builds, which don't use Autotools.
>
> We faced a similar problem with pcre_chartables.c. Check r5927; probably
> we can do something similar.
>
> David Fifield

The problem with r5927 is a bit different then this one, since in pcre.h
case this manifests only in distclean, whereas in r5927 it was cleared
apon clean too. So, should I go the trouble and fix this one? Worth
mentioning is that this file is the *only* one that leaves the repo
dirty upon make distclean.

By looking around, the only fixes I can suggest are to remove the file
from the distclean target or removing the autogeneration part, since the
file looks pretty static to me, even if generated.

PS: I want to take this one off my todo list.

Regards,
Shinnok
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/