Re: [nping] WINAPI becoming undefined

[Gisle Vanem <gvanem () broadpark no>]

"David Fifield" <david () bamsoftware com> wrote:

> This is getting outside of my offhand Windows header knowledge. Could
> you perhaps trace the problem backwards with
>
> #ifndef WINAPI
> #error WINAPI undefined
> #endif

I've done that too and other things (like studying the 'gcc -E'
output). I've not found the problem, so I'll leave winfix.cc with my 
fix of putting system-headers ahead of local headers.

But I must say the state of building and understanding the file-structure
etc. of Nmap/Win is rather hard and confusing. 

* Take the hand-edited *config*.h files for instance. The 
 "#define HAVE_OPENSSL" is defined in 4 different places!
 Couldn't there be a master-file "mswin32/win_config.h" where all 
 this stuff gets placed? 

* There are duplicates of several files. E.g. 2 "winclude.h" files.
 Also confusing and unneeded IMHO. If the motive for this was that 
 'nping' could be built outside the nmap source-tree, it's understandable.
 But I doubt that will work. Has anyone tried that?

We need more ideas on this. I'm willing to provide some of the 
patches (to the project/solution files too), but I've not been involved 
with nmap so long... I don't know the details and motivation of why 
things are as they are. The original authors better step forward, if they're
still there?

Maybe my "rant" should have gone in a different email. But last time I 
uttered some ideas on this, I got no feedback.

--gv
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/