Nmap Development mailing list archives

Re: nping debugging message bugs


From: David Fifield <david () bamsoftware com>
Date: Sat, 19 Mar 2011 00:47:21 -0700

On Thu, Mar 10, 2011 at 10:29:58PM +0200, Toni Ruottu wrote:
Some of the nping debug message titles are said to be for the opposite
direction than the key that is retrieved. Is this a bug?

cyberix@eval:~/my/src/nmap/nmap/nping$ grep C2S *|grep S2C
EchoClient.cc:  outPrint(DBG_4,"Session Key CIPHER_C2S:");
print_hexdump(DBG_4,ctx.getCipherKeyS2C(), MAC_KEY_LEN);
EchoClient.cc:  outPrint(DBG_4,"Session Key CIPHER_S2C:");
print_hexdump(DBG_4,ctx.getCipherKeyC2S(), MAC_KEY_LEN);
EchoServer.cc:  outPrint(DBG_3,"Session Key CIPHER_C2S:");
print_hexdump(DBG_3,ctx->getCipherKeyS2C(), MAC_KEY_LEN);
EchoServer.cc:  outPrint(DBG_3,"Session Key CIPHER_S2C:");
print_hexdump(DBG_3,ctx->getCipherKeyC2S(), MAC_KEY_LEN);
EchoServer.cc:            outPrint(DBG_3,"Session Key
MAC_C2S_INITIAL:"); print_hexdump(DBG_3,ctx.getMacKeyS2C(),
MAC_KEY_LEN);

Yes, it looks like a bug. Can you make a patch to fix it? Offhand, I
don't know whether the string or the function call is the part that's
incorrect.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/


Current thread: