Re: hddtemp-info.nse

[Toni Ruottu <toni.ruottu () iki fi>]

You are probably right. I got lost while trying to read the library
code. I just did not want to do the decision of combining the two
options. I am happy that you did. It makes the API clearer. Good work.

On Mon, Jan 10, 2011 at 2:26 AM, David Fifield <david () bamsoftware com> wrote:
> On Thu, Dec 30, 2010 at 02:21:10PM +0200, Toni Ruottu wrote:
> > The included patch fixes a bug in the comm library. Previously the
> > options got trashed when someone was used get_banner, like
> > hddtemp-info did. The fix also adds a new parameter eopts to method
> > tryssl. The new parameter can be used to set options for the early
> > receive, which takes place before the actual data exchange.
> >
> >   --Toni
> >
> > p.s. It is a bit illogical that the early receive option is turned on
> > from the regular opts, and not from the eopts, but I did not change
> > this as some code might rely on turning it on the old way.
>
> I don't understand the reasoning for breaking out a separate options
> table. The module documentation already explains what is supposed to be
> supported in the options. It was a bug that opencon didn't support them.
>
> Anyway, I used the part of your patch that changed sd:receive to read,
> and it now works like I expect.
>
> David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/