Nmap Development mailing list archives
RE: nmap-dev Digest, Vol 70, Issue 74
From: Lx <lglx303 () gmail com>
Date: Wed, 2 Feb 2011 20:01:29 -0500
Lixor_ -----Original Message----- From: nmap-dev-request () insecure org Sent: Monday, January 31, 2011 4:09 PM To: nmap-dev () insecure org Subject: nmap-dev Digest, Vol 70, Issue 74 Send nmap-dev mailing list submissions to nmap-dev () insecure org To subscribe or unsubscribe via the World Wide Web, visit http://cgi.insecure.org/mailman/listinfo/nmap-dev or, via email, send a message with subject or body 'help' to nmap-dev-request () insecure org You can reach the person managing the list at nmap-dev-owner () insecure org When replying, please edit your Subject line so it is more specific than "Re: Contents of nmap-dev digest..." Today's Topics: 1. Re: [NSE] Improved version of ms-sql-info (Chris Woodbury) ---------------------------------------------------------------------- Message: 1 Date: Mon, 31 Jan 2011 15:08:58 -0600 From: Chris Woodbury <chris3e3 () gmail com> Subject: Re: [NSE] Improved version of ms-sql-info To: Patrik Karlsson <patrik () cqure net> Cc: Nmap-Dev <nmap-dev () insecure org> Message-ID: <AANLkTimc5wW-ZAzgQULDz8Dur3x0YnvD-HWgDMYYG=VN () mail gmail com> Content-Type: text/plain; charset="iso-8859-1" On Sun, Jan 30, 2011 at 4:04 AM, Patrik Karlsson <patrik () cqure net> wrote:
Although I'm no Lua expert here are some quick comments on the code: * You should probably avoid the leading underscore convention for instance variables and function names to avoid confusion with metamethods. [1]
Good tip, and thanks for the reference. I've replaced the leading double-underscores with single underscores. Do you think that's still likely to cause problems? My background is in object-oriented programming, so I'm wondering whether I'm trying to impose too much on Lua. :)
? On that same note, all of my ToString and your new ToBytes method could be changed to __tostring (as I've done in my later libraries). ? This would make it possible to do: local p = PreLoginPacket:new() socket:send( tostring(p) )
I did this and then realized that the ToString methods here return two values (PacketType, PacketData). I didn't think it was worth it to make all the necessary changes to make that work, so I reverted back to the original. I [The entire original message is not included] _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- RE: nmap-dev Digest, Vol 70, Issue 74 Lx (Feb 02)