Re: OpenBSD nmap/libnetutil/netutil.cc header files error -- quick and dirty patch attached

[pourlori () hushmail com]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've attached a typescript showing the compilation errors between
revision 18423 and 18424,
then I've appended the output of the compilation without the
typedef.

Note that the typedef may be dangerous, it looks like it's used to
old a timestamp value, which
could not fit on a 32 bit integer one day, this is why I said my
patch was dirty. It's a temporary fix.
The 2 includes added in revision 18424 are not needed for other
operating systems (I believe), adding a preprocessor
#ifndef OPENBSD_FLAG_STUFF could be a good idea.

Regards,

Lori.

On Tue, 29 Jun 2010 04:52:45 +0200 David Fifield
<david () bamsoftware com> wrote:
> On Fri, Jun 25, 2010 at 09:43:57PM +0200, pourlori () hushmail com
> wrote:
> > I've had some difficulties compiling libnetutil on OpenBSD 4.7 -
> > Stable.
> > Here's a small patch that I made in order to get the compilation
> > done properly.
> >
> > I hope you will find it useful and make a proper patch, the
> > comments in the files are somewhat funny,
> > like "Why doesn't OpenBSD do that ?", I've no answer and I
> couldn't
> > find any relevant documentation on the subject,
>
> Can you please show us the exact error messages that you get?
>
> I'm curious why this is needed. I don't see the symbol n_time used
> anywhere.
>
> typedef u_int32_t n_time; /* defined somewhere else, a PITA to
> include */
>
> Most of the contents of netutil.cc were taken from tcpip.cc. Can
> you
> check if moving includes from tcpip.cc or tcpip.h fixes the
> problem?
>
> David Fifield
-----BEGIN PGP SIGNATURE-----
Charset: UTF8
Note: This signature can be verified at https://www.hushtools.com/verify
Version: Hush 3.0

wpwEAQMCAAYFAkwp3f8ACgkQ1NyWFvn1c0v88AP/fsUvo0IFy0aSiL06No0Qi2aaOi2N
F2M29OC10AeH6VkEdpP6e1faFn9qUUhJVBUEyxfrywvevoPl/cAF2NiqWZ8jGeVsx4AS
4w5iobMwkMT9TjO1hnXx2rI2SM4jUVb4xfughP4Xc2O0tAZiMLqncFHBwAzeAbmCyVL5
c7rEzpM=
=QdGv
-----END PGP SIGNATURE-----

Attachment: nmap_typescript_netutil.txt
Description:

Attachment: nmap_typescript_netutil.txt.sig
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/