Re: [PATCH] Compilation failing without Lua (--without-liblua)

[Brandon Enright <bmenrigh () ucsd edu>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 24 Jan 2010 03:42:51 -0500 or thereabouts Patrick Donnelly
<batrick () batbytes com> wrote:

> Hi Brandon,
>
> On Sun, Jan 24, 2010 at 3:35 AM, Brandon Enright <bmenrigh () ucsd edu>
> wrote:
> > A coworker of mine noticed if you try to configure Nmap using
> > - --without-liblua the compilation is failing.  Attached is a patch
> > that fixes the compile by wrapping a #ifndef NOLUA around a few
> > statements. For some reason I don't understand, without Lua, the
> > C++ standard string header isn't in scope/defined when compiling
> > Target.h so I had to add that too.  Adding the #ifndef directives
> > seems rather non-controversial to me but adding #include <string>
> > to Target.h might not be the "right" fix.
> >
> > Is there any issue with me applying this patch as-is?
>
> nse_main.h #includes <string>

Yeah so do a few other headers that seemed like they should have been
taking care of the problem.

> Patch looks fine to me.

Cool, I just checked it in.  Thanks for the look-over.

> Off-topic: Wouldn't --without-nse be a better name for
> --without-liblua? We don't have --without-python to exclude Zenmap
> after all :)

Yeah I agree.  The name comes from back when Diman Todorov was working
on NSE before NSE really have a well-defined name.  We were somewhat
chaotically referring to it as several things and calling it liblua
made plenty of sense.  I know distributions like Gentoo rely on
"--without-liblua" so while we should change it, we should wait until
after 5.2x

Brandon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAktcDZQACgkQqaGPzAsl94Lq8wCgiyDv4zJK/gEQIeWAlHRKL9fC
3lsAn2nCELwjm3HjI8ywGGIJinjcm+mX
=FhLo
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/