Re: [nmap-svn] r13494 - zenmap/radialnet/gui

[David Fifield <david () bamsoftware com>]

On Wed, Jun 03, 2009 at 11:34:24PM -0600, David Fifield wrote:
> On Wed, Jun 03, 2009 at 05:52:39PM -0700, Fyodor wrote:
> > On Wed, Jun 03, 2009 at 12:24:57PM -0700, commit-mailer () insecure org wrote:
> > > Log:
> > > Some changes to the topology saving patch:
> >
> > Thanks, these work well in my testing.  But regarding this one:
> >
> > > * Don't automatically add a file name extension to the user's name.
> >
> > I realize that it was broken before this change because it would add
> > the extension even if there already was one.  But maybe we should
> > still add the extension when none at all is specified?  Many Windows
> > programs, including Microsoft Word, do this.  It seems more likely
> > that the user expects an extension to be added than that the want to
> > create a PDF, PNG, PS or SVG file without any extension.
> >
> > If you don't want to add the extension by default, perhaps we could
> > just give a message such as "add .png extension to filename?" when
> > someone tries to save w/o extension.
>
> How about this patch? It automatically updates the file name in the
> dialog when you change the type. So if it is "a.png" and you change the
> selection to PDF, it changes to "a.pdf". If you really want a different
> extension or no extension after that, you can edit the file name after
> selecting the type and no automatic changes will be made unless you
> change the type again.
>
> Or maybe there's a standard for how these types of save dialogs are
> supposed to work? I like in the GIMP how the default option is "by
> extension."

I added a "By extension" option to the chooser and made it the default.
If you pick a different type, the file name's extension is changed
automatically. If you choose "By extension" and the extension is
unrecognized, you get prompted to enter another or choose a file type.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org