Re: [NSE] nmap library problems

["Patrick Donnelly" <batrick.donnelly () gmail com>]

On Fri, Dec 12, 2008 at 9:23 PM, David Fifield <david () bamsoftware com> wrote:
> On Fri, Dec 12, 2008 at 09:19:30PM -0700, Patrick Donnelly wrote:
> > Apologies this was incorrect. The current implementation used a "do
> > nothing" function in place of the optional parameter which I confused
> > as the actual return value.
>
> Does this change your patch at all?

No it does not. I shortened the newtry function (while maintaining
equivalence) like many others.

> I do plan to review your patch, it's just that I have been pretty deep
> in the performance project lately. Of course anyone else can review it
> and help everyone out. This can be as simple as applying the patch and
> reporting works/doesn't, or you can ask question's about Patrick's new
> code or make implementation suggestions.

I appreciate it, thanks.

Cheers,

-- 
-Patrick Donnelly

"One of the lessons of history is that nothing is often a good thing
to do and always a clever thing to say."

-Will Durant

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org