Nmap Development mailing list archives

Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters

From: David Fifield <david () bamsoftware com>
Date: Mon, 13 Oct 2008 00:19:30 -0600

On Sun, Oct 12, 2008 at 10:08:09AM -0600, Patrick Donnelly wrote:

You got this error because ripeQuery.nse did not check the return
value of  socket:connect(). The problem is resolved as ripeQuery now
uses the comm library which properly checks the return values.


The real issue here is that something is causing a segmentation fault
(large problem). The script's method of achieving this is incidental.
The cause of this segmentation fault still needs to be addressed.


It's not a segmentation fault any more. It seems that back in r6171 I
added checks for a socket descriptor being -1, so now it's just an
assertion failure. I'm glad to hear that the particular case I cited has
been fixed, though I think it is still the case that a socket:connect
call can fail and the script will continue running.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org

Current thread:

[NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 10)
  - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 10)
    - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 10)
  - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters David Fifield (Oct 10)
    - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 12)
    - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 12)
    - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters David Fifield (Oct 12)
    - Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 12)