Re: [NSE][PATCH] OpenSSL bindings for NSE

[Sven Klemm <sven () c3d2 de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Fifield wrote:
> This looks very good. I can't think of any remaining issues that would
> be a barrier to integration. I tested it with and without OpenSSL on
> GNU/Linux (and Windows, see below). Please commit it.
>
> There are a few small things that should be changed or fixed, but they
> can be done shortly after the merge takes place. Here's my list:
>
> * The patch you attached didn't apply to mswin32/nmap.vcproj. Also the
>   project file doesn't include the new nse_openssl.* files, leading to a
>   compile error:
> nse_init.cc(253) : error C2065: 'OPENSSLLIBNAME' : * undeclared identifier
> nse_init.cc(253) : error C2065: 'luaopen_openssl' : undeclared identifier

I've added the nse_openssl files to the project file. Can't test this
one as I have no Windows build system.

> * Delete the nse_hash.* files.

I've deleted those files but the MD5 and SHA1 functions/files still
need to be removed from nbase.

> * The nmap_config.h file referred to in nse_openssl.* doesn't exist in
>   the Windows build, leading to another compile error. The file
>   nmap_winconfig.h should be used instead (#ifdef WIN32, see Target.cc).
>   But in this case it appears to be used only for HAVE_OPENSSL, which
>   the Unix build already checks for before including the files. Since
>   OpenSSL is presumed to be available on Windows, that include can be
>   removed and replaced with more specific ones.

Including nmap_winconfig.h for WIN32 now.

> * I would like to see the new fingerprint module be moved back into a
>   part of ssh1 or ssh2. It could even be a part of both, with one module
>   grabbing it from the other. "fingerprint" is too general a name for a
>   module that only handles SSH fingerprints, especially when Nmap has
>   things like OS and version fingerprints. And because it only does SSH,
>   it should be part of an SSH module.

I moved the fingerprint functions into the ssh1 module.

Cheers,
Sven

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjtNl4ACgkQevlgTHEIT4aQTACfdqGkM9m0KOeBRb9OZZzjiHeo
fr0An2T0O0v2F2JBU6tZX4DRjMP0ScVP
=/XuC
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org