Re: [NSE][PATCH] OpenSSL bindings for NSE

[Fyodor <fyodor () insecure org>]

On Thu, Sep 04, 2008 at 10:58:16PM +0200, Sven Klemm wrote:
> Adding furthing functions is trivial.

Great.  If OpenSSH binding hash functions are merged in to /nmap, we
need to remember to remove them from Nbase.  I don't want to have
both.

> I favor adding a to_hex method to the lua string class because this
> will result in the least code duplication and will also be a very nice
> addition as you can easily transform any string into a hexencoded
> string. It is a change to liblua though but the change is quite
> minimal and in my opinion extremely useful and as liblua is included
> in the nmap code I think modifying it is okay.

In general, modifying Liblua would cause us problems.  Right now, I
think, Nmap uses an existing system Liblua if it exists in preference
to the one included with Nmap.  That avoids bloating Nmap, and makes
compilation faster too.  Similarly, Linux distributions and the like
want to use existing shared libraries.  If we muck with Liblua, we'll
have to change Nmap to always link with our hacked version, which
would be unfortunate.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org